lkml.org 
[lkml]   [2016]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] drm/amdgpu: enable powerplay unconditionally
Date
> -----Original Message-----
> From: Arnd Bergmann [mailto:arnd@arndb.de]
> Sent: Friday, September 30, 2016 12:21 PM
> To: Deucher, Alexander; Koenig, Christian
> Cc: Arnd Bergmann; David Airlie; Zhou, Jammy; Zhu, Rex; dri-
> devel@lists.freedesktop.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] drm/amdgpu: enable powerplay unconditionally
>
> Using the newly exported amd_set_clockgating_by_smu function in the
> main amdgpu driver
> means that we can no longer build the driver without also enabling the
> powerplay
> component, otherwise we get this link error:
>
> ERROR: "amd_set_clockgating_by_smu"
> [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
>
> The easiest way to avoid this error is to always enable the Kconfig symbol
> when
> the amdgpu driver is enabled.
>
> Fixes: a8ca34136453 ("drm/amdgpu: set gfx clock gating for tonga/polaris.")
> Fixes: 1bb08f91b0f6 ("drm/amdgpu: set system clock gating for
> tonga/polaris.")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> It's quite likely that there is a better way to do this, as the separation
> of the drivers is intentional. If my patch isn't acceptable, please come
> up with a different solution.

I've already removed the kconfig symbol altogether:
https://lists.freedesktop.org/archives/dri-devel/2016-September/119647.html

Alex

> ---
> drivers/gpu/drm/amd/powerplay/Kconfig | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/Kconfig
> b/drivers/gpu/drm/amd/powerplay/Kconfig
> index af380335b425..6d4f155a0453 100644
> --- a/drivers/gpu/drm/amd/powerplay/Kconfig
> +++ b/drivers/gpu/drm/amd/powerplay/Kconfig
> @@ -1,6 +1,4 @@
> config DRM_AMD_POWERPLAY
> - bool "Enable AMD powerplay component"
> - depends on DRM_AMDGPU
> - default n
> + def_bool DRM_AMDGPU
> help
> select this option will enable AMD powerplay component.
> --
> 2.9.0

\
 
 \ /
  Last update: 2016-09-30 18:59    [W:0.025 / U:3.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site