Messages in this thread | | | Date | Fri, 30 Sep 2016 14:33:57 +0200 | From | Johannes Thumshirn <> | Subject | Re: [PATCH 1/3] cw1200: Don't leak memory if krealloc failes |
| |
On Fri, Sep 30, 2016 at 02:29:39PM +0200, Johannes Berg wrote: > > > + tmp = krealloc(buf->begin, size, GFP_KERNEL | GFP_DMA); > > + if (tmp) { > > > I think that check is inverted? > > johannes
Fu.. you're right, of cause it's !tmp.
I'll resend.
Thanks, Johannes
-- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
| |