Messages in this thread | | | From | Richard Genoud <> | Date | Fri, 30 Sep 2016 13:45:47 +0200 | Subject | Re: [PATCHv4 2/3] tty/serial: at91: fix hardware handshake with GPIOs |
| |
2016-09-30 13:16 GMT+02:00 Alexandre Belloni <alexandre.belloni@free-electrons.com>: > On 30/09/2016 at 13:04:28 +0200, Richard Genoud wrote : >> Anyway, the problematics setups are all the setups with USMODE_HWHS >> enabled on platform without Fifos or PDC, >> i.e. all platforms but sama5d2 (Cyrille, correct me if I'm wrong). >> > > This is a wrong assumption, at91rm9200 to at91sam9g45 all have a pdc. > Please, don't break those platforms. > > The only affected platforms are sam9x5, sama5d3 and sama5d4. Have you tested them ?
And why are you saying that rm9200 and g45 will be broken with this patch ? If they have a pdc, they will fall in the case: (atmel_use_pdc_rx(port) || atmel_use_fifo(port)) and thus use: mode |= ATMEL_US_USMODE_HWHS;
won't they ?
| |