lkml.org 
[lkml]   [2016]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 1/2] tile-module: Use kmalloc_array() in module_alloc()
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Sat, 3 Sep 2016 20:40:57 +0200

    * A multiplication for the size determination of a memory allocation
    indicated that an array data structure should be processed.
    Thus use the corresponding function "kmalloc_array".

    * Replace the specification of a data type by a pointer dereference
    to make the corresponding size determination a bit safer according to
    the Linux coding style convention.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    arch/tile/kernel/module.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/arch/tile/kernel/module.c b/arch/tile/kernel/module.c
    index 2305084..dce4120 100644
    --- a/arch/tile/kernel/module.c
    +++ b/arch/tile/kernel/module.c
    @@ -43,7 +43,7 @@ void *module_alloc(unsigned long size)
    int npages;

    npages = (size + PAGE_SIZE - 1) / PAGE_SIZE;
    - pages = kmalloc(npages * sizeof(struct page *), GFP_KERNEL);
    + pages = kmalloc_array(npages, sizeof(*pages), GFP_KERNEL);
    if (pages == NULL)
    return NULL;
    for (; i < npages; ++i) {
    --
    2.9.3
    \
     
     \ /
      Last update: 2016-09-17 09:58    [W:4.032 / U:0.568 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site