Messages in this thread Patch in this message | | | From | Christophe JAILLET <> | Subject | [PATCH] RDS: Simplify code | Date | Sat, 3 Sep 2016 07:33:29 +0200 |
| |
Calling 'list_splice' followed by 'INIT_LIST_HEAD' is equivalent to 'list_splice_init'.
This has been spotted with the following coccinelle script: ///// @@ expression y,z; @@
- list_splice(y,z); - INIT_LIST_HEAD(y); + list_splice_init(y,z);
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- net/rds/loop.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/rds/loop.c b/net/rds/loop.c index f2bf78de5688..c3e6da4fdf97 100644 --- a/net/rds/loop.c +++ b/net/rds/loop.c @@ -167,8 +167,7 @@ void rds_loop_exit(void) /* avoid calling conn_destroy with irqs off */ spin_lock_irq(&loop_conns_lock); - list_splice(&loop_conns, &tmp_list); - INIT_LIST_HEAD(&loop_conns); + list_splice_init(&loop_conns, &tmp_list); spin_unlock_irq(&loop_conns_lock); list_for_each_entry_safe(lc, _lc, &tmp_list, loop_node) { -- 2.7.4
| |