lkml.org 
[lkml]   [2016]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/3] DT: EVM: add LEDs
From
Date

> Am 29.09.2016 um 07:14 schrieb Rob Herring <robh+dt@kernel.org>:
>
> On Tue, Sep 27, 2016 at 12:26 AM, H. Nikolaus Schaller
> <hns@goldelico.com> wrote:
>
> The subject gives no indication this is for OMAP. Please follow
> standard patterns.

Already fixed. Please see v2.

>
>> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
>> ---
>> arch/arm/boot/dts/omap5-uevm.dts | 60 ++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 60 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts
>> index be659e8..19f5f0a 100644
>> --- a/arch/arm/boot/dts/omap5-uevm.dts
>> +++ b/arch/arm/boot/dts/omap5-uevm.dts
>> @@ -17,6 +17,66 @@
>> device_type = "memory";
>> reg = <0x80000000 0x7F000000>; /* 2032 MB */
>> };
>> +
>> + evm_leds {
>> + compatible = "gpio-leds";
>> +
>> + led@1 {
>
> Drop the unit address. There's no reg property.
>
>> + label = "omap5:red:led";
>> + gpios = <&gpio9 17 GPIO_ACTIVE_HIGH>;
>> + linux,default-trigger = "mmc0";
>> + default-state = "off";
>> + };
>> +
>> + led@2 {
>> + label = "omap5:green:led";
>> + gpios = <&gpio9 18 GPIO_ACTIVE_HIGH>;
>> + linux,default-trigger = "mmc1";
>> + default-state = "off";
>> + };
>> +
>> + led@3 {
>> + label = "omap5:blue:led";
>> + gpios = <&gpio9 19 GPIO_ACTIVE_HIGH>;
>> + linux,default-trigger = "mmc2";
>> + default-state = "off";
>> + };
>> +
>> + led@4 {
>> + label = "omap5:green:led1";
>> + gpios = <&gpio9 2 GPIO_ACTIVE_HIGH>;
>> + linux,default-trigger = "default-on";
>> + default-state = "off";
>> + };
>> +
>> + led@5 {
>> + label = "omap5:green:led2";
>> + gpios = <&gpio9 3 GPIO_ACTIVE_HIGH>;
>> + linux,default-trigger = "default-on";
>> + default-state = "off";
>> + };
>> +
>> + led@6 {
>> + label = "omap5:green:led3";
>> + gpios = <&gpio9 4 GPIO_ACTIVE_HIGH>;
>> + linux,default-trigger = "heartbeat";
>> + default-state = "off";
>> + };
>> +
>> + led@7 {
>> + label = "omap5:green:led4";
>> + gpios = <&gpio9 5 GPIO_ACTIVE_HIGH>;
>> + linux,default-trigger = "heartbeat";
>> + default-state = "off";
>> + };
>> +
>> + led@8 {
>> + label = "omap5:green:led5";
>> + gpios = <&gpio9 6 GPIO_ACTIVE_HIGH>;
>> + linux,default-trigger = "heartbeat";
>> + default-state = "off";
>> + };
>> + };
>> };
>>
>> &hdmi {
>> --
>> 2.7.3
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe devicetree" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html

\
 
 \ /
  Last update: 2016-09-29 07:19    [W:0.079 / U:17.900 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site