Messages in this thread | | | Subject | Re: [PATCH] include/linux/property.h: fix typo/compile error | From | "Rafael J. Wysocki" <> | Date | Fri, 30 Sep 2016 02:21:03 +0200 |
| |
On 9/29/2016 4:10 AM, John Youn wrote: > This fixes commit d76eebfa175e ("include/linux/property.h: fix build > issues with gcc-4.4.4"). > > With that commit we get the following compile error when using the > PROPERTY_ENTRY_INTEGER_ARRAY macro. > > ../include/linux/property.h:201:39: error: ‘u32_data’ undeclared (first > use in this function) > PROPERTY_ENTRY_INTEGER_ARRAY(_name_, u32, _val_) > ^ > ../include/linux/property.h:193:17: note: in definition of macro > ‘PROPERTY_ENTRY_INTEGER_ARRAY’ > { .pointer = { _type_##_data = _val_ } }, \ > ^ > > This needs a '.' to reference the union member. It seems this was just > overlooked here since it is done correctly in similar constructs in > other parts of the original commit. > > This fix is in preparation of upcoming commits that will use this macro. > > Fixes: commit d76eebfa175e ("include/linux/property.h: fix build issues with gcc-4.4.4") > Signed-off-by: John Youn <johnyoun@synopsys.com>
Applied.
Thanks, Rafael
> --- > include/linux/property.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/property.h b/include/linux/property.h > index 3a2f9ae..856e50b 100644 > --- a/include/linux/property.h > +++ b/include/linux/property.h > @@ -190,7 +190,7 @@ struct property_entry { > .length = ARRAY_SIZE(_val_) * sizeof(_type_), \ > .is_array = true, \ > .is_string = false, \ > - { .pointer = { _type_##_data = _val_ } }, \ > + { .pointer = { ._type_##_data = _val_ } }, \ > } > > #define PROPERTY_ENTRY_U8_ARRAY(_name_, _val_) \
| |