lkml.org 
[lkml]   [2016]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets
From
Date
On Wed, 2016-09-28 at 05:57 -0700, Eric Dumazet wrote:

> Note that some programs could fail to compile with the added union
> anyway.
>
> Some gcc versions are unable to compile a static init with an union
>
> struct inet_diag_req_v2 foo = { .pad = 0, sdiag_family = AF_INET, };
>
> When I cooked my recent fq commit I simply removed a pad and replaced
> it :
>
> git show fefa569a9d4bc4 -- include

This is a bit different of course, since struct tc_fq_qd_stats is only
one way : Kernel produces the content and gives it to user space.

User space should probably not need to initialize such a structure, but
who knows what a programmer can write ;)


\
 
 \ /
  Last update: 2016-09-28 15:02    [W:0.239 / U:0.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site