lkml.org 
[lkml]   [2016]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 0/5] ISDN-Gigaset: Fine-tuning for three function implementations
    From
    Date
    On Mon, 2016-09-26 at 17:37 +0200, SF Markus Elfring wrote:
    > Some update suggestions were taken into account
    > from static source code analysis.
    >
    > Markus Elfring (5):
    >   Use kmalloc_array() in two functions
    >   Improve another size determination in gigaset_initcs()
    >   Delete an error message for a failed memory allocation
    >   Release memory in gigaset_initcs() after an allocation failure
    >   Enclose two expressions for the sizeof operator by parentheses
    >
    >  drivers/isdn/gigaset/common.c | 31 ++++++++++++++++---------------
    >  1 file changed, 16 insertions(+), 15 deletions(-)

    Two of the five patches introduced bugs. The rest of the series isn't
    free of various nits either. Of course, I was in no mood to be lenient
    when I looked at those three patches.

    I won't take any of these patches, sorry.


    Paul Bolle

    \
     
     \ /
      Last update: 2016-09-28 13:57    [W:4.164 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site