Messages in this thread | | | Subject | Re: [PATCH] Staging: android: fix permissions style | From | Joe Perches <> | Date | Tue, 27 Sep 2016 10:43:48 -0700 |
| |
On Mon, 2016-09-26 at 22:02 +0100, Ramiro Oliveira wrote: > Change permissions from symbolic to octal. [] > diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c [] > @@ -204,10 +204,10 @@ device_initcall(lowmem_init); > * not really modular, but the easiest way to keep compat with existing > * bootargs behaviour is to continue using module_param here. > */ > -module_param_named(cost, lowmem_shrinker.seeks, int, S_IRUGO | S_IWUSR); > +module_param_named(cost, lowmem_shrinker.seeks, int, 0644); > module_param_array_named(adj, lowmem_adj, short, &lowmem_adj_size, > > S_IRUGO | S_IWUSR); > module_param_array_named(minfree, lowmem_minfree, uint, &lowmem_minfree_size, > S_IRUGO | S_IWUSR);
Seems odd to fix the other two but not this one.
> -module_param_named(debug_level, lowmem_debug_level, uint, S_IRUGO | S_IWUSR); > +module_param_named(debug_level, lowmem_debug_level, uint, 0644);
| |