lkml.org 
[lkml]   [2016]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] staging: vt6656: Add spaces around '+' operator
From
Date
On Mon, 2016-09-26 at 14:48 -0300, Martin Alonso wrote:
> Fix coding style issue "spaces preferred around '+'
> detected by checkpatch.pl in dpc.c file.
[]
> diff --git a/drivers/staging/vt6656/dpc.c b/drivers/staging/vt6656/dpc.c
[]
> @@ -75,8 +75,8 @@ int vnt_rx_data(struct vnt_private *priv, struct vnt_rcb *ptr_rcb,
>  
> >   skb_data = (u8 *)skb->data;
>  
> - rx_sts = skb_data+4;
> - rx_rate = skb_data+5;
> + rx_sts = skb_data + 4;
> + rx_rate = skb_data + 5;
>  
>   /* real Frame Size = USBframe_size -4WbkStatus - 4RxStatus */
>   /* -8TSF - 4RSR - 4SQ3 - ?Padding */

You might as well make rx_rate u8 instead of u8 *
and change the uses of rx_rate. rx_sts isn't used
anywhere at all and could be removed.

\
 
 \ /
  Last update: 2016-09-26 20:03    [W:0.262 / U:0.692 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site