lkml.org 
[lkml]   [2016]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -v2 6/9] sched/rtmutex: Refactor rt_mutex_setprio()
On Mon, 26 Sep 2016 14:32:19 +0200
Peter Zijlstra <peterz@infradead.org> wrote:

> @@ -3586,9 +3625,7 @@ void rt_mutex_setprio(struct task_struct
> goto out_unlock;
> }
>
> - rt_mutex_update_top_task(p);
> -
> - trace_sched_pi_setprio(p, prio);
> + trace_sched_pi_setprio(p, prio); /* broken */

Not a very comforting comment to see during a review ;-)

I'll hold off giving a full review of this patch while in the airport.
My mind needs a bit more "quiet" to do this one.

-- Steve

> oldprio = p->prio;
>
> if (oldprio == prio)

\
 
 \ /
  Last update: 2016-09-26 18:58    [W:1.959 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site