Messages in this thread | | | Date | Mon, 26 Sep 2016 18:50:38 +0200 (CEST) | From | Julia Lawall <> | Subject | Re: [PATCH 5/5] ISDN-Gigaset: Enclose two expressions for the sizeof operator by parentheses |
| |
On Mon, 26 Sep 2016, SF Markus Elfring wrote:
> >>> @@ -53,7 +53,7 @@ void gigaset_dbg_buffer(enum debuglevel level, const unsigned char *msg, > >>> { > >>> unsigned char outbuf[80]; > >>> unsigned char c; > >>> - size_t space = sizeof outbuf - 1; > >>> + size_t space = sizeof(outbuf - 1); > > > >> wrong ... > >> think that is 7 instead of 79. > > > > > > Well, it's sizeof(pointer) so either 4 or 8, but still, > > what Markus proposes here is _wrong_. > > You are right at this place. > > > > Markus, do you know the script probably has a lower > > style conversion defect introduction rate than you do > > when doing these mechanical things. > > Would it be nice if the script "checkpatch.pl" could avoid to point > such a false positive out anyhow?
checkpatch reports:
WARNING: sizeof outbuf should be sizeof(outbuf) #56: FILE: drivers/isdn/gigaset/common.c:56: + size_t space = sizeof outbuf - 1;
There is nothing wrong with the report,
julia
> > > > Please use it to verify what you are doing before > > submitting more defective patches. > > Do you expect a resend for this update step so that an other statement > in the function "gigaset_initdriver" would eventually be adjusted? > > Regards, > Markus > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
| |