Messages in this thread | | | Subject | Re: [PATCH 5/5] ISDN-Gigaset: Enclose two expressions for the sizeof operator by parentheses | From | SF Markus Elfring <> | Date | Mon, 26 Sep 2016 18:45:09 +0200 |
| |
>>> @@ -53,7 +53,7 @@ void gigaset_dbg_buffer(enum debuglevel level, const unsigned char *msg, >>> { >>> unsigned char outbuf[80]; >>> unsigned char c; >>> - size_t space = sizeof outbuf - 1; >>> + size_t space = sizeof(outbuf - 1); > >> wrong ... >> think that is 7 instead of 79. > > > Well, it's sizeof(pointer) so either 4 or 8, but still, > what Markus proposes here is _wrong_.
You are right at this place.
> Markus, do you know the script probably has a lower > style conversion defect introduction rate than you do > when doing these mechanical things.
Would it be nice if the script "checkpatch.pl" could avoid to point such a false positive out anyhow?
> Please use it to verify what you are doing before > submitting more defective patches.
Do you expect a resend for this update step so that an other statement in the function "gigaset_initdriver" would eventually be adjusted?
Regards, Markus
| |