lkml.org 
[lkml]   [2016]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] ASoC: tpa6130a2: unmerge power enable error path from power disable path
Date
>> I doubt that copying 7 lines into error path is better than having a tiny
>> logic with return values, but still here it is.
>
> Consider what happens if someone wants to change the code...

I believe that "undo poweron" and "poweroff" sequences still will have
to remain the same. This having two copies of code is more error-prone
than having one.

Nikita

\
 
 \ /
  Last update: 2016-09-26 18:16    [W:0.045 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site