Messages in this thread | | | Date | Mon, 26 Sep 2016 17:32:41 +0200 (CEST) | From | Jiri Kosina <> | Subject | Re: [PATCH] Fix a issue that Alps Touchpad cursor does not work |
| |
On Fri, 23 Sep 2016, Masaki Ota wrote:
> fix Touchpad cursor does not work after touching Touchpad > by 3 or more fingers.
Please provide more verbose changelog -- namely why the current code is wrong and how does your patch fixes it.
Thanks.
> Signed-off-by: Masaki Ota <masaki.ota@jp.alps.com> > --- > drivers/hid/hid-alps.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c > index 048befd..610df92 100644 > --- a/drivers/hid/hid-alps.c > +++ b/drivers/hid/hid-alps.c > @@ -190,16 +190,16 @@ static int alps_raw_event(struct hid_device *hdev, > if (z != 0) { > input_mt_report_slot_state(hdata->input, > MT_TOOL_FINGER, 1); > + input_report_abs(hdata->input, > + ABS_MT_POSITION_X, x); > + input_report_abs(hdata->input, > + ABS_MT_POSITION_Y, y); > + input_report_abs(hdata->input, > + ABS_MT_PRESSURE, z); > } else { > input_mt_report_slot_state(hdata->input, > MT_TOOL_FINGER, 0); > - break; > } > - > - input_report_abs(hdata->input, ABS_MT_POSITION_X, x); > - input_report_abs(hdata->input, ABS_MT_POSITION_Y, y); > - input_report_abs(hdata->input, ABS_MT_PRESSURE, z); > - > } > > input_mt_sync_frame(hdata->input);
-- Jiri Kosina SUSE Labs
| |