Messages in this thread | | | Date | Sun, 25 Sep 2016 22:33:13 +0200 | From | Gustavo Padovan <> | Subject | Re: [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static |
| |
Hi Baoyou,
2016-09-22 Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
> On Tue, Sep 20, 2016 at 06:23:33PM +0530, Sumit Semwal wrote: > > Hi Baoyou, > > > > On 20 September 2016 at 16:43, Gustavo Padovan <gustavo@padovan.org> wrote: > > > 2016-09-18 Baoyou Xie <baoyou.xie@linaro.org>: > > > > > >> We get 1 warning when building kernel with W=1: > > >> drivers/dma-buf/sw_sync.c:87:23: warning: no previous prototype for 'sync_timeline_create' [-Wmissing-prototypes] > > >> > > >> In fact, this function is only used in the file in which it is > > >> declared and don't need a declaration, but can be made static. > > >> So this patch marks it 'static'. > > >> > > >> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> > > >> --- > > >> drivers/dma-buf/sw_sync.c | 2 +- > > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > Thanks for finding this. > > > > Thanks for the patch; this doesn't apply to mainline yet, since the > > de-staging of sw_sync code is queued for 4.9 via Greg-KH's tree. > > CC'ing him. > > > > Greg, would it be possible to please take this via your tree? > > If someone resends it to me with the needed acks and reviewed-by, I > will.
Could please resend this to Greg with all the acks and reviewed-by in the commit message? Thanks.
Gustavo
| |