Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH] HSI: omap_ssi_core: move function declaration to header file | Date | Sat, 24 Sep 2016 10:58:15 +0200 |
| |
On Saturday, September 24, 2016 1:11:56 PM CEST Baoyou Xie wrote: > --- > drivers/hsi/clients/ssi_protocol.c | 2 -- > include/linux/hsi/hsi.h | 1 + > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/hsi/clients/ssi_protocol.c b/drivers/hsi/clients/ssi_protocol.c > index 6031cd1..fe86444 100644 > --- a/drivers/hsi/clients/ssi_protocol.c > +++ b/drivers/hsi/clients/ssi_protocol.c > @@ -45,8 +45,6 @@ > #include <linux/hsi/hsi.h> > #include <linux/hsi/ssi_protocol.h> > > -void ssi_waketest(struct hsi_client *cl, unsigned int enable); > - > #define SSIP_TXQUEUE_LEN 100 > #define SSIP_MAX_MTU 65535 > #define SSIP_DEFAULT_MTU 4000 >
Maybe the declaration should be moved to include/linux/hsi/ssi_protocol.h instead of include/linux/hsi/hsi.h? It's not completely clear as the exported function is a bit of a layering violation.
Arnd
| |