Messages in this thread | | | Date | Fri, 23 Sep 2016 17:08:37 +0200 | From | Greg KH <> | Subject | Re: [PATCH] usb: xhci: mark xhci_unmap_td_bounce_buffer() static |
| |
On Fri, Sep 23, 2016 at 09:46:13PM +0800, Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/usb/host/xhci-ring.c:608:6: warning: no previous prototype for 'xhci_unmap_td_bounce_buffer' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is > declared and don't need a declaration, but can be made static. > so this patch marks this function with 'static'.
Any reason you aren't using sparse for all of these 'static' functions you are finding? It should be easier than using 'W=1'.
thanks,
greg k-h
| |