lkml.org 
[lkml]   [2016]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] drm/tilcdc: fix wrong error handling
From
Date
On 09/23/16 14:47, Sean Paul wrote:
> On Fri, Sep 23, 2016 at 3:52 AM, Daniel Schultz <d.schultz@phytec.de> wrote:
>> When 'component_bind_all' fails it should not try to unbind components
>> in the error handling. This will produce a null pointer kernel panic when
>> no component exist.
>>
>> This patch changes the order of the error handling. Now, it will only
>> unbind components if the are bound. Otherwise, the module will jump to
>> an error label below.
>>
>> Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
>
> Reviewed-by: Sean Paul <seanpaul@chromium.org>
>

Thanks, for both. Should I pick this one :)?

BR,
Jyri

>> ---
>> drivers/gpu/drm/tilcdc/tilcdc_drv.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
>> index d278093..d491610 100644
>> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
>> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
>> @@ -315,13 +315,13 @@ fail_irq_uninstall:
>> fail_vblank_cleanup:
>> drm_vblank_cleanup(dev);
>>
>> -fail_mode_config_cleanup:
>> - drm_mode_config_cleanup(dev);
>> -
>> fail_component_cleanup:
>> if (priv->is_componentized)
>> component_unbind_all(dev->dev, dev);
>>
>> +fail_mode_config_cleanup:
>> + drm_mode_config_cleanup(dev);
>> +
>> fail_external_cleanup:
>> tilcdc_remove_external_encoders(dev);
>>
>> --
>> 1.9.1
>>

\
 
 \ /
  Last update: 2016-09-23 14:01    [W:0.671 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site