lkml.org 
[lkml]   [2016]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] clocksource: timer-imx-gpt: Unmap and free region obtained by of_iomap and kzalloc
On Thu, 22 Sep 2016, Arvind Yadav wrote:

> Subject: clocksource: timer-imx-gpt: Unmap and free region obtained by of_iomap and kzalloc

These subject lines are useless and way too long. A patch subject should
describe the nature of the patch and not elaborate what the patch is doing
technically.

clocksrouce/timer-imz-gpt: Prevent resource leaks in error path

would be a proper subject line which makes it entirely clear what this
patch is about.

From your subject line I have to read the patch itself to figure that
out. It's completely irrelevant whether that resource is a mapping or
allocated memory. The point is that the error path leaks resource(s).

See Documentation/SubmittingPatches. There you'll find a lengthy
explanation about changelogs and summary lines in particular.

Thanks,

tglx



\
 
 \ /
  Last update: 2016-09-23 00:02    [W:1.641 / U:0.504 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site