Messages in this thread | | | Date | Thu, 22 Sep 2016 01:49:20 -0400 (EDT) | Subject | Re: [PATCH] cxgb4: fix signed wrap around when decrementing index idx | From | David Miller <> |
| |
From: Colin King <colin.king@canonical.com> Date: Tue, 20 Sep 2016 15:48:45 +0100
> From: Colin Ian King <colin.king@canonical.com> > > Change predecrement compare to post decrement compare to avoid an > unsigned integer wrap-around comparison when decrementing idx in > the while loop. > > For example, when idx is zero, the current situation will > predecrement idx in the while loop, wrapping idx to the maximum > signed integer and cause out of bounds reads on rxq_info->msix_tbl[idx]. > > Signed-off-by: Colin Ian King <colin.king@canonical.com>
This doesn't apply cleanly to the 'net' tree, please respin.
| |