Messages in this thread | | | Date | Thu, 22 Sep 2016 11:58:58 +0100 | From | Mark Brown <> | Subject | Re: [PATCH] usb: gadget: Add uevent to notify userspace |
| |
On Thu, Sep 22, 2016 at 06:53:12PM +0800, Baolin Wang wrote: > From: Badhri Jagan Sridharan <Badhri@google.com> > > Some USB managament on userspace (like Android system) rely on the uevents > generated by the composition driver to generate user notifications. Thus this > patch adds uevents to be generated whenever USB changes its state: connected, > disconnected, configured. > > The original code was created by Badhri Jagan Sridharan, and I did some > optimization. > > CC: Badhri Jagan Sridharan <Badhri@google.com> > Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
If you're sending a patch someone else wrote you need their Signed-off-by - if they didn't provide one you need to talk to them about that and get it.
> +config USB_CONFIGFS_UEVENT > + boolean "Uevent notification of Gadget state" > + depends on USB_CONFIGFS > + help > + Enable uevent notifications to userspace when the gadget > + state changes. The gadget can be in any of the following > + three states: "CONNECTED/DISCONNECTED/CONFIGURED"
Why not just generate the events unconditionally? [unhandled content-type:application/pgp-signature] | |