lkml.org 
[lkml]   [2016]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 10/14] GPU-DRM-OMAP: Use kmalloc_array() in omap_gem_attach_pages()
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Wed, 21 Sep 2016 17:37:04 +0200

    A multiplication for the size determination of a memory allocation
    indicated that an array data structure should be processed.
    Thus use the corresponding function "kmalloc_array".

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/gpu/drm/omapdrm/omap_gem.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/gpu/drm/omapdrm/omap_gem.c
    index 505dee0..e4f1924 100644
    --- a/drivers/gpu/drm/omapdrm/omap_gem.c
    +++ b/drivers/gpu/drm/omapdrm/omap_gem.c
    @@ -259,7 +259,7 @@ static int omap_gem_attach_pages(struct drm_gem_object *obj)
    * DSS, GPU, etc. are not cache coherent:
    */
    if (omap_obj->flags & (OMAP_BO_WC|OMAP_BO_UNCACHED)) {
    - addrs = kmalloc(npages * sizeof(*addrs), GFP_KERNEL);
    + addrs = kmalloc_array(npages, sizeof(*addrs), GFP_KERNEL);
    if (!addrs) {
    ret = -ENOMEM;
    goto free_pages;
    --
    2.10.0
    \
     
     \ /
      Last update: 2016-09-23 00:00    [W:4.022 / U:0.512 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site