Messages in this thread | | | Date | Wed, 21 Sep 2016 18:20:44 +0800 | From | Baoquan He <> | Subject | Re: [PATCH v5 6/8] iommu/amd: Do not re-enable dev table entries in kdump |
| |
On 09/20/16 at 02:42pm, Joerg Roedel wrote: > On Thu, Sep 15, 2016 at 11:03:24PM +0800, Baoquan He wrote: > > This enabling should have been done in normal kernel. It's unnecessary > > to enable it again in kdump kernel. > > > > And clean up the function comments of init_device_table_dma. > > Well, no. We don't want to make any assumptions on what the previous > kernel did and what it did not. The init_device_table_dma() code should > run anyway.
Yes, right. I forget people could set amd_iommu=off in 1st kernel, but remove it in kdump kernel. Will change and merge the comment clean up into another patch.
>
| |