lkml.org 
[lkml]   [2016]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] cpufreq: fix up conversion to hotplug state machine
    Date
    On Tuesday, September 20, 2016 04:56:28 PM Sebastian Andrzej Siewior wrote:
    > The function cpufreq_register_driver() returns zero on success and since
    > commit 27622b061eb4 ("cpufreq: Convert to hotplug state machine")
    > erroneously a positive number. Due to the "if (x) assume_error" construct
    > all callers assumed an error and things went south.
    > This patch resets the return value back to zero in the success case.
    >
    > Fixes: 27622b061eb4 ("cpufreq: Convert to hotplug state machine")
    > Reported-by: Borislav Petkov <bp@alien8.de>
    > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

    ACK

    > ---
    > drivers/cpufreq/cpufreq.c | 1 +
    > 1 file changed, 1 insertion(+)
    >
    > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
    > index e0bc632a259e..8b44de4d7438 100644
    > --- a/drivers/cpufreq/cpufreq.c
    > +++ b/drivers/cpufreq/cpufreq.c
    > @@ -2503,6 +2503,7 @@ int cpufreq_register_driver(struct cpufreq_driver *driver_data)
    > if (ret < 0)
    > goto err_if_unreg;
    > hp_online = ret;
    > + ret = 0;
    >
    > pr_debug("driver %s up and running\n", driver_data->name);
    > goto out;
    >

    \
     
     \ /
      Last update: 2016-09-20 18:11    [W:2.793 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site