lkml.org 
[lkml]   [2016]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH V2 for-next 14/19] IB/hns: Validate mtu when modified qp
    Date
    From: Lijun Ou <oulijun@huawei.com>

    The mtu should be validated when modify qp,so we check it.

    Signed-off-by: Lijun Ou <oulijun@huawei.com>
    Signed-off-by: Peter Chen <luck.chen@huawei.com>
    Reviewed-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
    Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
    ---
    PATCH V2: Addressed Leon Romanovsky's comments
    Link: https://lkml.org/lkml/2016/9/13/39
    PATCH V1: Initial Submit
    ---
    drivers/infiniband/hw/hns/hns_roce_qp.c | 15 +++++++++++++++
    1 file changed, 15 insertions(+)

    diff --git a/drivers/infiniband/hw/hns/hns_roce_qp.c b/drivers/infiniband/hw/hns/hns_roce_qp.c
    index dd1b214..6a38909 100644
    --- a/drivers/infiniband/hw/hns/hns_roce_qp.c
    +++ b/drivers/infiniband/hw/hns/hns_roce_qp.c
    @@ -32,6 +32,7 @@
    */

    #include <linux/platform_device.h>
    +#include <rdma/ib_addr.h>
    #include <rdma/ib_umem.h>
    #include "hns_roce_common.h"
    #include "hns_roce_device.h"
    @@ -657,6 +658,7 @@ int hns_roce_modify_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr,
    struct device *dev = &hr_dev->pdev->dev;
    int ret = -EINVAL;
    int p;
    + enum ib_mtu active_mtu;

    mutex_lock(&hr_qp->mutex);

    @@ -687,6 +689,19 @@ int hns_roce_modify_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr,
    }
    }

    + if (attr_mask & IB_QP_PATH_MTU) {
    + p = attr_mask & IB_QP_PORT ? (attr->port_num - 1) : hr_qp->port;
    + active_mtu = iboe_get_mtu(hr_dev->iboe.netdevs[p]->mtu);
    +
    + if (attr->path_mtu > IB_MTU_2048 ||
    + attr->path_mtu < IB_MTU_256 ||
    + attr->path_mtu > active_mtu) {
    + dev_err(dev, "attr path_mtu(%d)invalid while modify qp",
    + attr->path_mtu);
    + goto out;
    + }
    + }
    +
    if (attr_mask & IB_QP_MAX_QP_RD_ATOMIC &&
    attr->max_rd_atomic > hr_dev->caps.max_qp_init_rdma) {
    dev_err(dev, "attr max_rd_atomic invalid.attr->max_rd_atomic=%d\n",
    --
    1.9.1

    \
     
     \ /
      Last update: 2016-09-20 18:10    [W:2.805 / U:1.184 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site