Messages in this thread | | | Date | Fri, 2 Sep 2016 16:11:22 -0600 | From | Jason Gunthorpe <> | Subject | Re: [PATCH] tpm: move struct tpm_class_ops to drivers/char/tpm/tpm.h |
| |
On Sat, Sep 03, 2016 at 12:48:03AM +0300, Jarkko Sakkinen wrote: > The struct tpm_class_ops is not used outside the TPM driver. Thus, > it can be safely move to drivers/char/tpm/tpm.h.
No, this is the wrong direction.
The goal is to make things more like other subsystems, so we should be moving struct tpm_chip into the public header, and that requires ops to be in the public header.
This is why I put ops here in the first place.
Jason
| |