Messages in this thread | | | From | Vivien Didelot <> | Subject | Re: [PATCH net-next 3/3] net: dsa: mv88e6xxx: make global2 code optional | Date | Fri, 02 Sep 2016 13:32:11 -0400 |
| |
Hi Andrew,
Andrew Lunn <andrew@lunn.ch> writes:
>> I agree. Does the following snippet looks OK? >> >> >> #ifndef CONFIG_NET_DSA_MV88E6XXX_GLOBAL2 >> if (mv88e6xxx_has(chip, MV88E6XXX_FLAG_GLOBAL2)) { >> dev_err(chip->dev, "Missing support for Global 2 registers\n"); > > I would include the name of the option which needs enabling. Also it > is not really missing. It has not been enabled. > > "The required compile time options needed to support this switch have > not been enabled. Please enable: CONFIG_NET_DSA_MV88E6XXX_GLOBAL2"
That is much better indeed, respining.
Thanks!
Vivien
| |