Messages in this thread | | | Date | Sun, 18 Sep 2016 13:33:32 +0200 | From | Thomas Petazzoni <> | Subject | Re: [PATCH] net: mvneta: mark symbols static where possible |
| |
Hello,
On Sun, 18 Sep 2016 17:20:45 +0800, Baoyou Xie wrote: > We get 2 warnings when building kernel with W=1: > drivers/net/ethernet/marvell/mvneta.c:639:27: warning: no previous prototype for 'mvneta_get_stats64' [-Wmissing-prototypes] > drivers/net/ethernet/marvell/mvneta.c:3529:5: warning: no previous prototype for 'mvneta_ethtool_set_link_ksettings' [-Wmissing-prototypes] > > In fact, these functions are only used in the file in which they are > declared and don't need a declaration, but can be made static. > so this patch marks these functions with 'static'. > > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
-- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
| |