lkml.org 
[lkml]   [2016]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] net: hns: add function declarations in hns_dsaf_mac.h
    Date
    On Sunday, September 18, 2016 5:11:36 PM CEST Baoyou Xie wrote:
    > We get 2 warnings when building kernel with W=1:
    > drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c:246:6: warning: no previous prototype for 'hns_dsaf_srst_chns' [-Wmissing-prototypes]
    > drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c:276:6: warning: no previous prototype for 'hns_dsaf_roce_srst' [-Wmissing-prototypes]
    >
    > In fact, these two functions are not declared in any file, but should
    > be declared in a header file, thus can be recognized in other file.
    >
    > So this patch adds the declarations into
    > drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h
    >
    > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
    >

    Why can't these be declared static?

    Arnd

    \
     
     \ /
      Last update: 2016-09-18 22:38    [W:9.195 / U:0.216 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site