lkml.org 
[lkml]   [2016]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/5] u64_stats: Introduce IRQs disabled helpers
On Fri, Sep 02, 2016 at 04:35:54PM +0200, Paolo Bonzini wrote:
>
>
> On 02/09/2016 16:03, Frederic Weisbecker wrote:
> > static inline unsigned int u64_stats_fetch_begin(const struct u64_stats_sync *syncp)
> > {
> > -#if BITS_PER_LONG==32 && defined(CONFIG_SMP)
> > - return read_seqcount_begin(&syncp->seq);
> > -#else
> > -#if BITS_PER_LONG==32
> > +#if BITS_PER_LONG==32 && !defined(CONFIG_SMP)
> > preempt_disable();
> > +#else
>
> This should be #endif, or this side ends without a "return" statement.

Good catch!

Thanks Paolo!

\
 
 \ /
  Last update: 2016-09-18 15:35    [W:0.063 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site