lkml.org 
[lkml]   [2016]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 4/6] firmware-qemu_fw_cfg: Improve a size determination in fw_cfg_build_symlink()
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Sun, 18 Sep 2016 14:02:02 +0200

    Replace the specification of a data structure by a pointer dereference
    as the parameter for the operator "sizeof" to make the corresponding size
    determination a bit safer according to the Linux coding style convention.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/firmware/qemu_fw_cfg.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c
    index a834d01..a4b108a 100644
    --- a/drivers/firmware/qemu_fw_cfg.c
    +++ b/drivers/firmware/qemu_fw_cfg.c
    @@ -399,7 +399,7 @@ static int fw_cfg_build_symlink(struct kset *dir,
    dir = to_kset(ko);
    } else {
    /* create new subdirectory kset */
    - subdir = kzalloc(sizeof(struct kset), GFP_KERNEL);
    + subdir = kzalloc(sizeof(*subdir), GFP_KERNEL);
    if (!subdir) {
    ret = -ENOMEM;
    break;
    --
    2.10.0
    \
     
     \ /
      Last update: 2016-09-18 14:56    [W:4.015 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site