lkml.org 
[lkml]   [2016]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 0/2] PCI/AER: Remove module parameters
Date
Bjorn,
Can we extend this aerdriver to support AER from a root complex integrated endpoint? Root complex event collector has the same job as root port in this case.

It looks that both port driver and aer driver check PCI_EXP_TYPE_ROOT_PORT/PCI_EXP_TYPE_UPSTREAM/PCI_EXP_TYPE_DOWNSTREAM only.
portdrv_pci.c:127, aerdrv.c:86

Is it just a simple addition of PCI_EXP_TYPE_RC_EC to above two places? Is there any difference to recover a root complex integrated endpoint? (compared with devices connected to root port).

Thanks.
--CQ

> -----Original Message-----
> From: linux-pci-owner@vger.kernel.org [mailto:linux-pci-
> owner@vger.kernel.org] On Behalf Of Bjorn Helgaas
> Sent: Wednesday, September 14, 2016 1:30 PM
> To: Bjorn Helgaas <bhelgaas@google.com>
> Cc: linux-pci@vger.kernel.org; Lance Ortiz <lance.ortiz@hpe.com>; Betty Dall
> <betty.dall@hpe.com>; Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>;
> Chen Gong <gong.chen@linux.intel.com>; KeithBuschkeith.busch@intel.com;
> Rafael J. Wysocki <rjw@rjwysocki.net>; linux-kernel@vger.kernel.org; Shuah
> Khan <shuahkh@osg.samsung.com>; Huang, Ying <ying.huang@intel.com>;
> Vijay Mohan Pandarathil <vijaymohan.pandarathil@hpe.com>; Derrick,
> Jonathan <jonathan.derrick@intel.com>
> Subject: Re: [PATCH 0/2] PCI/AER: Remove module parameters
>
> On Tue, Sep 06, 2016 at 05:19:22PM -0500, Bjorn Helgaas wrote:
> > I'd like to remove the aerdriver.nosourceid and aerdriver.forceload
> > kernel parameters. They seem like basically debugging things that are
> > not really supportable upstream.
> >
> > "nosourceid" may have some legitimate uses, but I'd rather it were
> > done via quirks with the flag Jon Derrick recently added so it happens
> > automatically, without users having to specify the parameter.
> >
> > I don't *know* of any actual users of either of these, but obviously
> > that doesn't mean there are none. Comments welcome.
> >
> > ---
> >
> > Bjorn Helgaas (2):
> > PCI/AER: Remove aerdriver.nosourceid kernel parameter
> > PCI/AER: Remove aerdriver.forceload kernel parameter
> >
> >
> > Documentation/PCI/pcieaer-howto.txt | 26 +++++++++-----------------
> > drivers/pci/pcie/aer/aerdrv.c | 7 +------
> > drivers/pci/pcie/aer/aerdrv.h | 8 --------
> > drivers/pci/pcie/aer/aerdrv_core.c | 31 ++++---------------------------
> > 4 files changed, 14 insertions(+), 58 deletions(-)
>
> I'm going to go out on a limb a little bit and apply these to pci/aer for v4.9.
> Please let me know if you trip over any issues.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in the
> body of a message to majordomo@vger.kernel.org More majordomo info at
> http://vger.kernel.org/majordomo-info.html

\
 
 \ /
  Last update: 2016-09-17 09:59    [W:0.735 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site