lkml.org 
[lkml]   [2016]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH net-next 13/14] rxrpc: Be consistent about switch value in rxrpc_send_call_packet()
    From
    Date
    rxrpc_send_call_packet() should use type in both its switch-statements
    rather than using pkt->whdr.type. This might give the compiler an easier
    job of uninitialised variable checking.

    Signed-off-by: David Howells <dhowells@redhat.com>
    ---

    net/rxrpc/output.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/net/rxrpc/output.c b/net/rxrpc/output.c
    index aa0507214b31..0b21ed859de7 100644
    --- a/net/rxrpc/output.c
    +++ b/net/rxrpc/output.c
    @@ -182,7 +182,7 @@ int rxrpc_send_call_packet(struct rxrpc_call *call, u8 type)
    &msg, iov, ioc, len);

    if (ret < 0 && call->state < RXRPC_CALL_COMPLETE) {
    - switch (pkt->whdr.type) {
    + switch (type) {
    case RXRPC_PACKET_TYPE_ACK:
    rxrpc_propose_ACK(call, pkt->ack.reason,
    ntohs(pkt->ack.maxSkew),
    \
     
     \ /
      Last update: 2016-09-18 01:21    [W:4.462 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site