lkml.org 
[lkml]   [2016]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/3] nvme/scsi: Remove power management support
On Thu, Sep 15, 2016 at 10:24:19PM -0700, Andy Lutomirski wrote:
> As far as I can tell, there is basically nothing correct about this
> code. It misinterprets npss (off-by-one). It hardcodes a bunch of
> power states, which is nonsense, because they're all just indices
> into a table that software needs to parse. It completely ignores
> the distinction between operational and non-operational states.
> And, until 4.8, if all of the above magically succeeded, it would
> dereference a NULL pointer and OOPS.
>
> Since this code appears to be useless, just delete it.

Yes, please!

Acked-by: Christoph Hellwig <hch@lst.de>

\
 
 \ /
  Last update: 2016-09-17 09:59    [W:0.533 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site