Messages in this thread | | | Date | Thu, 15 Sep 2016 12:07:42 +0300 | From | Leon Romanovsky <> | Subject | Re: [PATCH for-next 12/20] IB/hns: Return bad wr while post send failed |
| |
On Fri, Sep 09, 2016 at 06:30:43PM +0800, Salil Mehta wrote: > From: Lijun Ou <oulijun@huawei.com> > > While post failed, hns roce should return the wr failed to user. > We omitted this while qp type is wrong and fixed it. > > Signed-off-by: Lijun Ou <oulijun@huawei.com> > Signed-off-by: Dongdong Huang(Donald) <hdd.huang@huawei.com> > Reviewed-by: Wei Hu (Xavier) <xavier.huwei@huawei.com> > Signed-off-by: Salil Mehta <salil.mehta@huawei.com> > --- > drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c > index f4d2515..f0d6315 100644 > --- a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c > +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c > @@ -264,8 +264,10 @@ int hns_roce_v1_post_send(struct ib_qp *ibqp, struct ib_send_wr *wr, > } > ind++; > } else {
You should move the check of supported QPs to the beginning of post_send and don't enter into the loop at all.
> - dev_dbg(dev, "unSupported QP type\n"); > - break; > + dev_err(dev, "unSupported QP type\n");
During initial review of hns driver, Lijun was asked to canonize debug messages and don't use different styles and especially sUcH case.
> + ret = -EOPNOTSUPP; > + *bad_wr = wr;
IMHO, the proper thing is to return NULL, because this is not wrong wr.
> + goto out; > } > } > > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html [unhandled content-type:application/pgp-signature] | |