lkml.org 
[lkml]   [2016]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 08/12] x86/dumpstack: Pin the target stack in save_stack_trace_tsk()
On Thu, Sep 15, 2016 at 11:41:25AM -0700, Andy Lutomirski wrote:
> I also wouldn't mind trying to do something to prevent ever dumping
> the stack of an actively running task. It's definitely safe to dump:
>
> - current
>
> - any task that's stopped via ptrace, etc
>
> - any task on the current CPU if running atomically enough that the
> task can't migrate (which probably covers the nasty NMI cases, I hope)
>
> What's *not* safe AFAIK is /proc/PID/stack. I don't know if we can
> somehow fix that short of actually sending an interrupt or NMI to
> freeze the task if it's running. I'm also not sure it's worth
> worrying about it.

Yeah, I proposed a fix for /proc/PID/stack a while back:

https://lkml.kernel.org/r/cover.1424109806.git.jpoimboe@redhat.com

My idea was to use task_rq_lock() to lock the runqueue and then check
tsk->on_cpu. I think Peter wasn't too keen on it.

We'll need something similar for the livepatch consistency model.

--
Josh

\
 
 \ /
  Last update: 2016-09-17 09:59    [W:0.074 / U:0.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site