Messages in this thread | | | Date | Thu, 15 Sep 2016 11:43:16 -0400 | From | Theodore Ts'o <> | Subject | Re: [PATCH 1/6 linux-next] ext4: avoid EXT4_INODE_EXTENTS double checking |
| |
On Wed, Aug 24, 2016 at 10:03:15PM +0200, Fabian Frederick wrote: > ext4_collapse_range() and ext4_insert_range() > already checked inode flag at the beginning of function. > > Signed-off-by: Fabian Frederick <fabf@skynet.be>
Actually, these checks are required since the check at the beginning are done before taking the inode lock.
One could argue that we should get rid of the first check, since we don't need to optimize for the error case. But removing the second check is definitely wrong.
Cheers,
- Ted
| |