Messages in this thread | | | Date | Thu, 15 Sep 2016 16:51:31 +0200 | From | Greg KH <> | Subject | Re: [PATCH] staging: rts5208: Comparisons should place the constant on the right side of the test |
| |
On Thu, Sep 15, 2016 at 04:29:54PM +0200, Sergio Paracuellos wrote: > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> > --- > drivers/staging/rts5208/rtsx_card.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rts5208/rtsx_card.c b/drivers/staging/rts5208/rtsx_card.c > index 9a5cd63..551e3064 100644 > --- a/drivers/staging/rts5208/rtsx_card.c > +++ b/drivers/staging/rts5208/rtsx_card.c > @@ -645,7 +645,7 @@ int switch_ssc_clock(struct rtsx_chip *chip, int clk) > dev_dbg(rtsx_dev(chip), "Switch SSC clock to %dMHz (cur_clk = %d)\n", > clk, chip->cur_clk); > > - if ((clk <= 2) || (N > max_N)) { > + if ((clk <= 2) || (max_N < N)) {
Where is the constant?
The original code looks fine to me...
Also, I can't take patches where there is no changelog text, sorry.
greg k-h
| |