Messages in this thread | | | Subject | Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift gpio_mxc_init() to subsys_initcall level' | From | Guenter Roeck <> | Date | Wed, 14 Sep 2016 07:33:43 -0700 |
| |
On 09/14/2016 12:19 AM, Linus Walleij wrote: > On Wed, Sep 14, 2016 at 5:20 AM, Guenter Roeck <linux@roeck-us.net> wrote: > >> So, in other words, lots of bugs here. Nevertheless, I would suggest to keep >> using postcore_initcall(), at least until it is sure that all gpio clients handle >> -EPROBE_DEFER >> correctly. > > So can I just revert this patch in isolation? None of the other patches > depend on it? > Good question, if this was part of a series. If it was and can not be removed in isolation, it nevertheless introduces a regression. Obviously there was a reason for using postcore_initcall (which is quite evident in the crash), and I don't think it is a good idea to just change it without addressing the reason(s) first. Who knows what other platforms crash because of this change.
Guenter
| |