lkml.org 
[lkml]   [2016]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 6/6] selftests: move watchdog tests from Documentation/watchdog
From
Date
On 09/13/2016 02:33 PM, Timur Tabi wrote:
> Shuah Khan wrote:
>> Remove watchdog-test from Makefile to move the test to selftests.
>>
>> Add Makefile and .gitignore to for watchdog-test. watchdog-test will
>
> to for?

Thanks - will fix that.

>
>> not be run as part of selftests suite and will not be included in
>> install targets. It can be built separately for now.
>>
>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>> ---
>> Documentation/watchdog/src/.gitignore | 1 -
>> Documentation/watchdog/src/Makefile | 2 +-
>> Documentation/watchdog/src/watchdog-test.c | 105 -----------------------
>> tools/testing/selftests/watchdog/.gitignore | 1 +
>> tools/testing/selftests/watchdog/Makefile | 8 ++
>> tools/testing/selftests/watchdog/watchdog-test.c | 105 +++++++++++++++++++++++
>
> Please use -M when calling git-format-patch

okay.

>
>> 6 files changed, 115 insertions(+), 107 deletions(-)
>> delete mode 100644 Documentation/watchdog/src/watchdog-test.c
>> create mode 100644 tools/testing/selftests/watchdog/.gitignore
>> create mode 100644 tools/testing/selftests/watchdog/Makefile
>> create mode 100644 tools/testing/selftests/watchdog/watchdog-test.c
>>
>> diff --git a/Documentation/watchdog/src/.gitignore b/Documentation/watchdog/src/.gitignore
>> index ac90997..ff0ebb5 100644
>> --- a/Documentation/watchdog/src/.gitignore
>> +++ b/Documentation/watchdog/src/.gitignore
>> @@ -1,2 +1 @@
>> watchdog-simple
>> -watchdog-test
>
> Why not also watchdog-simple?
>

Is watchdog-simple a test or a sample/example? I thought this
is an example, and planning to move that under examples?

If this is a test, I will re-do the patch to include it.

thanks,
-- Shuah

\
 
 \ /
  Last update: 2016-09-17 09:59    [W:0.809 / U:0.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site