Messages in this thread | | | Subject | Re: [PATCH 1/2] PCI: save and restore device state during bus reset | From | Sinan Kaya <> | Date | Tue, 13 Sep 2016 13:22:42 -0400 |
| |
Hi Bjorn,
On 9/13/2016 12:42 PM, Bjorn Helgaas wrote: > > This comment is no longer correct (you don't leave the devices in > power-on state).
Sorry about that, I can fix the comment.
> >> + */ >> +void pci_reset_bridge_secondary_bus(struct pci_dev *dev) >> +{ >> + pci_bus_save_and_disable(dev->bus); > > "dev" is a bridge, and dev->bus is the bus on the *primary* side of > the bridge, so I think this saves and disables the bridge itself. > Don't you want dev->subordinate here instead?
Yes, I need the subordinate.
> >> + pcibios_reset_secondary_bus(dev); >> + pci_bus_restore(dev->bus); >> +} >> +EXPORT_SYMBOL_GPL(pci_reset_bridge_secondary_bus); >> +
-- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
| |