lkml.org 
[lkml]   [2016]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: KVM patches applied in weird order in -stable
[adding stable@ as this is a stable issue, not a 'normal' issue]

On Tue, Sep 13, 2016 at 03:51:00PM +0100, Matt Fleming wrote:
> Folks,
>
> While hunting down a performance issue involving KVM I was surprised
> to see "native_set_debugreg()" as the first entry in `perf top`.
>
> Digging deeper, it looks as though the following patches were applied
> in the wrong order in -stable. This is the order as they appear in
> Linus' tree,
>
> [0] commit 4e422bdd2f84 ("KVM: x86: fix missed hardware breakpoints")
> [1] commit 172b2386ed16 ("KVM: x86: fix missed hardware breakpoints")
> [2] commit 70e4da7a8ff6 ("KVM: x86: fix root cause for missed hardware breakpoints")
>
> but this is the order for linux-4.4.y
>
> [1] commit fc90441e728a ("KVM: x86: fix missed hardware breakpoints")
> [2] commit 25e8618619a5 ("KVM: x86: fix root cause for missed hardware breakpoints")
> [0] commit 0f6e5e26e68f ("KVM: x86: fix missed hardware breakpoints")
>
> The upshot is that KVM_DEBUGREG_RELOAD is always set when returning
> from kvm_arch_vcpu_load() in stable, but not in Linus' tree.

How would applying these in a different order cause breakage?

And if this is a problem, can you please send me a patch to fix it up?

thanks,

greg k-h

\
 
 \ /
  Last update: 2016-09-17 09:59    [W:1.259 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site