Messages in this thread | | | Date | Tue, 13 Sep 2016 15:33:01 +0200 | From | LABBE Corentin <> | Subject | Re: [PATCH v3 1/9] ethernet: add sun8i-emac driver |
| |
On Fri, Sep 09, 2016 at 04:15:27PM +0200, Andrew Lunn wrote: > Hi Corentin > > > +static int sun8i_emac_mdio_register(struct net_device *ndev) > > +{ > > + struct sun8i_emac_priv *priv = netdev_priv(ndev); > > + struct mii_bus *bus; > > + int ret; > > + > > + bus = mdiobus_alloc(); > > You can use devm_mdiobus_alloc() which will simplify your error > handling and unregister code. > > Andrew
Hello
Since the mdio bus is allocated on ndev/open, it need to be removed when ndev/stop is called. So devm_mdiobus_alloc cannot be used.
Regards
Corentin Labbe
| |