lkml.org 
[lkml]   [2016]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] irqchip/atmel-aic: Fix potential deadlock in ->xlate()
From
Date
On 13/09/16 12:23, Boris Brezillon wrote:
> On Tue, 13 Sep 2016 12:10:09 +0200
> Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
>
>> aic5_irq_domain_xlate() and aic_irq_domain_xlate() take the generic chip
>> lock without disabling interrupts, which can lead to a deadlock if an
>> interrupt occurs while the lock is held in one of these functions.
>>
>> Replace irq_gc_{lock,unlock}() calls by
>> raw_spin_{lock_irqsave,unlock_irqrestore}() ones to prevent this bug from
>> happening.
>>
>> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
>> Fixes: b1479ebb7720 ("irqchip: atmel-aic: Add atmel AIC/AIC5 drivers")
>> Cc: <stable@kernel.vger.org>
>
> Oops, should be
>
> Cc: <stable@vger.kernel.org>
>
> Do you want me to send a v2?

You might as well, so that tglx can pick the patch with my ack on it.

Thanks,

M.
--
Jazz is not dead. It just smells funny...

\
 
 \ /
  Last update: 2016-09-17 09:59    [W:0.059 / U:0.692 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site