lkml.org 
[lkml]   [2016]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] staging: rtl8712: fix coding style error reported from checkpatch
From
Date
On Mon, 2016-09-12 at 21:02 +0300, Omri Arad wrote:
[]
> diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
[]
> @@ -1976,9 +1976,9 @@ static int r871x_get_ap_info(struct net_device *dev,
>   if (pdata->length >= 32) {
>   if (copy_from_user(data, pdata->pointer, 32))
>   return -EINVAL;
> - data[32] = 0;
> + data[32] = 0;
>   } else {
> - return -EINVAL;
> + return -EINVAL;
>   }
>   spin_lock_irqsave(&(pmlmepriv->scanned_queue.lock), irqL);
>   phead = &queue->queue;

Please don't blindly follow checkpatch messages but look to see
how the code can be improved beyond what checkpatch emits.

Perhaps more pleasant to read would be to rewrite this block like:

if (pdata->length < 32 ||
copy_from_user(data, pdata->pointer, 32))
return -EINVAL;
data[32] = 0;

Perhaps as well the literal 32 uses here and the 33 in the declaration
of data uses should be some #define or sizeof or ARRAY_SIZE.


\
 
 \ /
  Last update: 2016-09-17 09:59    [W:0.392 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site