Messages in this thread | | | Subject | Re: [PATCH resend] staging: comedi: comedi_fops: coding style fixes | From | Ian Abbott <> | Date | Mon, 12 Sep 2016 19:00:55 +0100 |
| |
On 12/09/16 14:18, Matias Mucciolo wrote: > > From: Matias Mucciolo <mmucciolo@suteba.org.ar> >
Those three lines are unnecessary, especially the initial blank line. I'm not sure whether Greg will ask you to fix it up.
> - Fixed coding style in comedi_fops.c Symbolic to octal permission. > > Signed-off-by: Matias Mucciolo <mmucciolo@suteba.org.ar> > --- > drivers/staging/comedi/comedi_fops.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c > index 1999eed..bf922ea 100644 > --- a/drivers/staging/comedi/comedi_fops.c > +++ b/drivers/staging/comedi/comedi_fops.c > @@ -81,20 +81,20 @@ struct comedi_file { > (COMEDI_NUM_MINORS - COMEDI_NUM_BOARD_MINORS) > > static int comedi_num_legacy_minors; > -module_param(comedi_num_legacy_minors, int, S_IRUGO); > +module_param(comedi_num_legacy_minors, int, 0444); > MODULE_PARM_DESC(comedi_num_legacy_minors, > "number of comedi minor devices to reserve for non-auto-configured devices (default 0)" > ); > > unsigned int comedi_default_buf_size_kb = CONFIG_COMEDI_DEFAULT_BUF_SIZE_KB; > -module_param(comedi_default_buf_size_kb, uint, S_IRUGO | S_IWUSR); > +module_param(comedi_default_buf_size_kb, uint, 0644); > MODULE_PARM_DESC(comedi_default_buf_size_kb, > "default asynchronous buffer size in KiB (default " > __MODULE_STRING(CONFIG_COMEDI_DEFAULT_BUF_SIZE_KB) ")"); > > unsigned int comedi_default_buf_maxsize_kb > = CONFIG_COMEDI_DEFAULT_BUF_MAXSIZE_KB; > -module_param(comedi_default_buf_maxsize_kb, uint, S_IRUGO | S_IWUSR); > +module_param(comedi_default_buf_maxsize_kb, uint, 0644); > MODULE_PARM_DESC(comedi_default_buf_maxsize_kb, > "default maximum size of asynchronous buffer in KiB (default " > __MODULE_STRING(CONFIG_COMEDI_DEFAULT_BUF_MAXSIZE_KB) ")"); >
It looks like the octal permissions have been blessed from above (Linus), so this is good.
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
-- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=- -=( Web: http://www.mev.co.uk/ )=-
| |