lkml.org 
[lkml]   [2016]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 5/6] mfd: sun6i-prcm: Make it explicitly non-modular
    On Mon, 12 Sep 2016 10:40:53 -0400
    Paul Gortmaker <paul.gortmaker@windriver.com> wrote:

    > The Kconfig currently controlling compilation of this code is:
    >
    > drivers/mfd/Kconfig:config MFD_SUN6I_PRCM
    > drivers/mfd/Kconfig: bool "Allwinner A31 PRCM controller"
    >
    > ...meaning that it currently is not being built as a module by anyone.
    >
    > Lets remove the couple traces of modularity so that when reading the
    > driver there is no doubt it is builtin-only.
    >
    > Since module_platform_driver() uses the same init level priority as
    > builtin_platform_driver() the init ordering remains unchanged with
    > this commit.
    >
    > We also delete the MODULE_LICENSE tag etc. since all that information
    > is already contained at the top of the file in the comments.
    >
    > Cc: Samuel Ortiz <sameo@linux.intel.com>
    > Cc: Lee Jones <lee.jones@linaro.org>
    > Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
    > Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
    > Cc: Boris BREZILLON <boris.brezillon@free-electrons.com>

    Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>

    > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
    > ---
    > drivers/mfd/sun6i-prcm.c | 8 ++------
    > 1 file changed, 2 insertions(+), 6 deletions(-)
    >
    > diff --git a/drivers/mfd/sun6i-prcm.c b/drivers/mfd/sun6i-prcm.c
    > index 191173166d65..011fcc555945 100644
    > --- a/drivers/mfd/sun6i-prcm.c
    > +++ b/drivers/mfd/sun6i-prcm.c
    > @@ -9,7 +9,7 @@
    > */
    >
    > #include <linux/mfd/core.h>
    > -#include <linux/module.h>
    > +#include <linux/init.h>
    > #include <linux/of.h>
    >
    > struct prcm_data {
    > @@ -170,8 +170,4 @@ static struct platform_driver sun6i_prcm_driver = {
    > },
    > .probe = sun6i_prcm_probe,
    > };
    > -module_platform_driver(sun6i_prcm_driver);
    > -
    > -MODULE_AUTHOR("Boris BREZILLON <boris.brezillon@free-electrons.com>");
    > -MODULE_DESCRIPTION("Allwinner sun6i PRCM driver");
    > -MODULE_LICENSE("GPL v2");
    > +builtin_platform_driver(sun6i_prcm_driver);

    \
     
     \ /
      Last update: 2016-09-17 09:59    [W:4.374 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site