Messages in this thread | | | Date | Mon, 12 Sep 2016 12:12:30 +0530 | From | Viresh Kumar <> | Subject | Re: [PATCH 19/26] intel_pstate: constify local structures |
| |
On 11-09-16, 15:06, Julia Lawall wrote: > For structure types defined in the same file or local header files, find > top-level static structure declarations that have the following > properties: > 1. Never reassigned. > 2. Address never taken > 3. Not passed to a top-level macro call > 4. No pointer or array-typed field passed to a function or stored in a > variable. > Declare structures having all of these properties as const. > > Done using Coccinelle. > Based on a suggestion by Joe Perches <joe@perches.com>. > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > > --- > The semantic patch seems too long for a commit log, but is in the cover > letter. > > drivers/cpufreq/intel_pstate.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c > index bdbe936..4b5f8c3 100644 > --- a/drivers/cpufreq/intel_pstate.c > +++ b/drivers/cpufreq/intel_pstate.c > @@ -1029,7 +1029,7 @@ static struct cpu_defaults core_params = { > }, > }; > > -static struct cpu_defaults silvermont_params = { > +static const struct cpu_defaults silvermont_params = { > .pid_policy = { > .sample_rate_ms = 10, > .deadband = 0, > @@ -1050,7 +1050,7 @@ static struct cpu_defaults silvermont_params = { > }, > }; > > -static struct cpu_defaults airmont_params = { > +static const struct cpu_defaults airmont_params = { > .pid_policy = { > .sample_rate_ms = 10, > .deadband = 0, > @@ -1071,7 +1071,7 @@ static struct cpu_defaults airmont_params = { > }, > }; > > -static struct cpu_defaults knl_params = { > +static const struct cpu_defaults knl_params = { > .pid_policy = { > .sample_rate_ms = 10, > .deadband = 0, > @@ -1091,7 +1091,7 @@ static struct cpu_defaults knl_params = { > }, > }; > > -static struct cpu_defaults bxt_params = { > +static const struct cpu_defaults bxt_params = { > .pid_policy = { > .sample_rate_ms = 10, > .deadband = 0,
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
-- viresh
| |